[Bug]: Onesignal global type breaks other global types

[andersmar]

What happened?

Our own global types stopped working after installing the onesignal-vue3 package.

This is because it still uses the @vue/runtime-core in module declaration, whereas 'vue' should be used instead (vue docs).

index.d.ts

declare module '@vue/runtime-core' {
    interface ComponentCustomProperties {
        $OneSignal: IOneSignalOneSignal;
    }
}

index.ts

declare module '@vue/runtime-core' {
  export interface ComponentCustomProperties {
    $OneSignal: IOneSignalOneSignal;
  }
}

What browsers are you seeing the problem on?

Other

What operating system are you running?

w11 pro 22H2

Steps to reproduce?

1. install package
2. define custom global type elsewhere
3. write the custom properties in a vue template

What did you expect to happen?

I expected both types to work.

The change described fixes the problem.

Relevant log output

No response

[cepicdalim]

Facing with same issue and the proposal for fixing issue is legit.

"This is because it still uses the @vue/runtime-core in module declaration, whereas 'vue' should be used instead (vue docs)."

[rgomezp]

@cepicdalim @andersmar thanks for calling attention to this issue.

The change needs to be made here -- though this needs to be tested to ensure it's not a breaking change.

PRs here won't be merged since this package is code-generated. It actually needs to be fixed upstream, however. I want to make sure we understand all the implications of the change.

Considerations:

• module reference shift (will TypeScript setups or imports no longer recognize the $OneSignal property, causing type errors?)
• do downstream projects need to update their code?
• do we need to document this change?
• should we deprecate the old declaration before removing it?
• does vue2 face a similar issue?

cc @sherwinski

[kyng-cytro]

Currently working around this with bun patch