Omit misleading fatal-level log for wrappers #1468
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Omit misleading fatal-level log for wrappers that always happens and is alarming, and is regularly reported by SDK users.
Details
Log Fatal log for null app ID only on native SDK
Remove
setLaunchOptions
from OneSignal headerMotivation
Wrapper SDK users regularly report the alarming
FATAL: OneSignal AppId: (null) - AppId is null or format is invalid, stopping initialization
, and it is misleading, and hides the real issue they have, if any.Scope
An error log
Testing
Unit testing
Manual testing
Iphone 13 on iOS 17.5.1
OneSignalWrapper.sdkType
before calling init with null app ID and seeing logsAffected code checklist
Checklist
Overview
Testing
Final pass
This change is