Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 14 - Add Geolocation support for user's current location #23

Merged
merged 2 commits into from
Jul 14, 2024

Conversation

aaronbrethorst
Copy link
Member

@aaronbrethorst aaronbrethorst commented Jul 14, 2024

Add geolocation support for user's current location

Related Issues

#14

Description

This PR related to issue #14. Within this PR, the changes included are:

  1. If user opens the map, it will ask a permission to ask for a location
  2. When search component in add favorite location and search for location is clicked, the user's location will appear
  3. When users type in search component of add favorite location and search for location, the user's location will dissapear and replaced by searched locations

Media

Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2024-07-06.at.17.55.12.mp4

Test Instructions

To test this PR, you can do the following:

  1. Uninstall the OTPKitDemo app in your simulator
  2. Re-run, set the simulator location. For example, here
  3. See if location permission is asked. Grant the permission
  4. Open any origin or destination menu
  5. Try to tap on search component. When it's focused or tapped, the row of "My Location" should appear
  6. Try to type on the search component, "My Location" row should dissapear

Additional Context

This PR is rebased from this PR #20. If you want to check for changes for this PR only, you should merge PR first

@aaronbrethorst aaronbrethorst changed the title Issue14 add geolocation support Issue 14 - Add Geolocation support for user's current location Jul 14, 2024
Copy link
Member Author

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I can't approve 'my' own pull request (🙃) I'll include my feedback as discussed with you in a comment instead:

"My Location" when saved via favorites should include some sort of wayfinding information (e.g. an intersection or something else that will help the user identify the location)

I'll log this as a separate issue.

@aaronbrethorst aaronbrethorst merged commit bd4c382 into main Jul 14, 2024
4 checks passed
@aaronbrethorst aaronbrethorst deleted the Issue14-add-geolocation-support branch July 14, 2024 03:19
@aaronbrethorst aaronbrethorst mentioned this pull request Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants