Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove "Ideas for new ideas" section from Report List #1195

Merged
merged 3 commits into from
Apr 13, 2024

Conversation

sebesti0n
Copy link
Contributor

@sebesti0n sebesti0n commented Apr 1, 2024

Fixed #1194

Preview:

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with gradlew connectedObaGoogleDebugAndroidTest to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them for the initial submission of the pull request. When addressing comments on a pull request, please push a new commit per comment when possible (reviewers will squash and merge using GitHub merge tool)

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected. However, in addition to the comment in the values-it XML file, there's still a couple references to Ideascale in the codebase. Please do a find in files, locate them, and delete them.

onebusaway-android/src/main/res/values-it/strings.xml Outdated Show resolved Hide resolved
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see references to Ideascale in the codebase

@sebesti0n
Copy link
Contributor Author

I still see references to Ideascale in the codebase

Done sir

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks! 👍

@aaronbrethorst aaronbrethorst merged commit af5e1ae into OneBusAway:main Apr 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove broken feature
2 participants