Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #1121 - Correct Spacing #1128

Merged

Conversation

amrhossamdev
Copy link
Member

Fixed #1121

  • Increasing the margin between the two buttons
  • Refactor: Instead of using left and right it's better to use start and end for RTL support.

I have tested different scenarios for the two buttons like opening the arrivals list / using locations that don't have bike-sharing options

Screenshots:

correct2 correct1 Screenshot_1708878024

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with gradlew connectedObaGoogleDebugAndroidTest to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them for the initial submission of the pull request. When addressing comments on a pull request, please push a new commit per comment when possible (reviewers will squash and merge using GitHub merge tool)

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks for taking care of this :)

@aaronbrethorst aaronbrethorst merged commit 0c842ab into OneBusAway:main Feb 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI - Bike sharing floating action button incorrect spacing
2 participants