Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use p/invoke rather than ugly bash commands to locate Mono on Unix #911

Merged
merged 4 commits into from
Jul 14, 2017
Merged

Use p/invoke rather than ugly bash commands to locate Mono on Unix #911

merged 4 commits into from
Jul 14, 2017

Conversation

DustinCampbell
Copy link
Contributor

No description provided.

david-driscoll
david-driscoll approved these changes Jul 14, 2017
View reviewed changes
Copy link
Member

@david-driscoll david-driscoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this meant that bash always had to be available... even if they used something else like zsh... I need to use linux more.

filipw
filipw approved these changes Jul 14, 2017
View reviewed changes
Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice solution

@filipw
Copy link
Member

filipw commented Jul 14, 2017

all green after restart

@filipw filipw merged commit 27e1496 into OmniSharp:master Jul 14, 2017
@DustinCampbell DustinCampbell deleted the locate-mono branch August 30, 2017 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipw filipw filipw approved these changes

@david-driscoll david-driscoll david-driscoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DustinCampbell @filipw @david-driscoll