Add support for running/debugging NUnit tests #683
Conversation
Detect NUnit tests and return an appropriate feature name. When a test is executed, the test framework name must be set (xunit or nunit). If no test framework is set, xunit is used (for backwards compatibility).
|
This will also need VS Code change as it currently explicitly searches for Generally I think any 3rd party framework specific things shouldn't be embedded into OmniSharp, but at the same xunit/nunit are de facto standard for .NET testing so it's not a problem here imho. 👍 |
|
The VS Code side change is here: dotnet/vscode-csharp#996. |
|
great! |
| private static bool IsTestMethod(MethodDeclarationSyntax node, | ||
| SemanticModel sematicModel) | ||
| private bool IsTestMethod(MethodDeclarationSyntax node, | ||
| SemanticModel sematicModel, Func<ITypeSymbol, bool> predicate) |
| bool isTestMethod = false; | ||
| string featureName = null; | ||
|
|
||
| if(IsTestMethod(method, semanticModel, IsDerivedFromFactAttribute)) |
There was a problem hiding this comment.
spacing between 'if' and '('
| } | ||
|
|
||
| symbol = symbol.BaseType; | ||
| } while (symbol.Name != "Object"); |
There was a problem hiding this comment.
Formatting nit: while should go on separate line.
There was a problem hiding this comment.
More accurate way of doing this:
while (symbol.SpecialType != SpecialType.System_Object);
|
The changes in the VS Code plugin and in Omnisharp-Roslyn work independently. The new Omnisharp-Roslyn will work with the old plugin, and the new plugin will work with the "old" Omnisharp-Roslyn. In both cases xUnit testing still works. |
|
I hadn't looked carefully, but yes, it does appear that it'll still work. I had assumed that the change to the protocol would break things, but it looks OK. That said, I'll wait to pull the change into VS Code's master until I've got an OmniSharp build to support it. I want to be sure the feature lights up when I take the PR. |
|
Looks good to me, @DustinCampbell we still waiting on the minor nits? |
|
Sorry for taking so long to get back to this. Nope, I wasn't waiting on the nits. |
|
Updated the base branch. I'll go ahead and merge this once the CI build finishes. |
Detect NUnit tests and return an appropriate feature name. When a test
is executed, the test framework name must be set (xunit or nunit). If no
test framework is set, xunit is used (for backwards compatibility).