Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TextEdits support to InlayHints #2385

Merged
merged 10 commits into from
Apr 18, 2022
Merged

Add TextEdits support to InlayHints #2385

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
77eca56
Update Roslyn to 4.3.0-1.22215.1
JoeRobich Apr 16, 2022
4224a2b
Add TextEdits to InlayHints
JoeRobich Apr 16, 2022
850d6cd
Increase import completion timeout in tests
JoeRobich Apr 16, 2022
e5f8c7c
Fix typo
JoeRobich Apr 16, 2022
b346915
Use TextChangeHelper
JoeRobich Apr 16, 2022
2f88954
Fix EditorConfig Formatting test
JoeRobich Apr 16, 2022
1340c24
Fix analyzer test
JoeRobich Apr 17, 2022
4995db0
Fix Cake completion test.
JoeRobich Apr 17, 2022
2a76dd1
Remove AdditionalTextEdits from Cake completion items
JoeRobich Apr 18, 2022
c7b3354
Delay getting Completion instead of polling in LSP tests.
JoeRobich Apr 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Increase import completion timeout in tests
  • Loading branch information
@JoeRobich
JoeRobich committed Apr 16, 2022
commit 850d6cdc3fa6dae389775d0193743687e330d84d
12 changes: 6 additions & 6 deletions tests/OmniSharp.Cake.Tests/CompletionFacts.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ namespace OmniSharp.Cake.Tests
{
public class CompletionFacts : CakeSingleRequestHandlerTestFixture<CompletionHandler>
{
private const int ImportCompletionTimeout = 1000;
private const int ImportCompletionTimeout = 2000;
private readonly ILogger _logger;

public CompletionFacts(ITestOutputHelper testOutput) : base(testOutput)
Expand All @@ -30,7 +30,7 @@ public async Task ShouldGetCompletionFromHostObject()
{
const string input = @"TaskSe$$";

using (var testProject = await TestAssets.Instance.GetTestProjectAsync("CakeProject", shadowCopy : false))
using (var testProject = await TestAssets.Instance.GetTestProjectAsync("CakeProject", shadowCopy: false))
using (var host = CreateOmniSharpHost(testProject.Directory))
{
var fileName = Path.Combine(testProject.Directory, "build.cake");
Expand All @@ -50,7 +50,7 @@ public async Task ShouldGetCompletionFromDSL()
Inform$$
});";

using (var testProject = await TestAssets.Instance.GetTestProjectAsync("CakeProject", shadowCopy : false))
using (var testProject = await TestAssets.Instance.GetTestProjectAsync("CakeProject", shadowCopy: false))
using (var host = CreateOmniSharpHost(testProject.Directory))
{
var fileName = Path.Combine(testProject.Directory, "build.cake");
Expand All @@ -70,7 +70,7 @@ public async Task ShouldResolveFromDSL()
Inform$$
});";

using (var testProject = await TestAssets.Instance.GetTestProjectAsync("CakeProject", shadowCopy : false))
using (var testProject = await TestAssets.Instance.GetTestProjectAsync("CakeProject", shadowCopy: false))
using (var host = CreateOmniSharpHost(testProject.Directory))
{
var fileName = Path.Combine(testProject.Directory, "build.cake");
Expand All @@ -90,7 +90,7 @@ public async Task ShouldRemoveAdditionalTextEditsFromResolvedCompletions()
{
const string input = @"var regex = new Rege$$";

using (var testProject = await TestAssets.Instance.GetTestProjectAsync("CakeProject", shadowCopy : false))
using (var testProject = await TestAssets.Instance.GetTestProjectAsync("CakeProject", shadowCopy: false))
using (var host = CreateOmniSharpHost(testProject.Directory,
new[] { new KeyValuePair<string, string>("RoslynExtensionsOptions:EnableImportCompletion", "true") }))
{
Expand Down Expand Up @@ -141,7 +141,7 @@ class FooChild : Foo
}
";

using (var testProject = await TestAssets.Instance.GetTestProjectAsync("CakeProject", shadowCopy : false))
using (var testProject = await TestAssets.Instance.GetTestProjectAsync("CakeProject", shadowCopy: false))
using (var host = CreateOmniSharpHost(testProject.Directory))
{
var fileName = Path.Combine(testProject.Directory, "build.cake");
Expand Down
2 changes: 1 addition & 1 deletion tests/OmniSharp.Roslyn.CSharp.Tests/CompletionFacts.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ namespace OmniSharp.Roslyn.CSharp.Tests
{
public class CompletionFacts : AbstractTestFixture
{
private const int ImportCompletionTimeout = 1000;
private const int ImportCompletionTimeout = 2000;
private readonly ILogger _logger;

private string EndpointName => OmniSharpEndpoints.Completion;
Expand Down