Require a known good version of .NET SDK be installed. #2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
commented
Dec 8, 2021
| catch (MSBuildNotFoundException mnfe) | ||
| { | ||
| Console.Error.WriteLine(mnfe.Message); | ||
| return 0xbad; |
There was a problem hiding this comment.
Can make this a unique exit code.
| @@ -72,7 +72,7 @@ public static void RegisterDefaultInstance(this IMSBuildLocator msbuildLocator, | |||
| } | |||
| else | |||
| { | |||
| logger.LogError("Could not locate MSBuild instance to register with OmniSharp"); | |||
| throw new MSBuildNotFoundException("Could not locate MSBuild instance to register with OmniSharp."); | |||
There was a problem hiding this comment.
Further loading isn't useful and clutters the output.
| @@ -22,9 +22,17 @@ public override ImmutableArray<MSBuildInstance> GetInstances() | |||
| { | |||
|
|
|||
| #if NETCOREAPP | |||
| const string DotNetSdkVersion = "6.0.100"; | |||
There was a problem hiding this comment.
Should be easy to find and replace this version string.
filipw
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we fail when loading SDKs with mismatched NuGet.Framework, we can limit our SDK discovery to a known good SDK version.