Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog for 1.37.2 #1977

Merged
merged 3 commits into from
Oct 8, 2020

Conversation

nohwnd
Copy link
Contributor

@nohwnd nohwnd commented Oct 7, 2020

No description provided.

CHANGELOG.md Outdated
@@ -2,6 +2,7 @@
All changes to the project will be documented in this file.

## [1.37.2] - Not Yet Released
* Mono versions update in the readme (PR: [#1929](https://github.com/OmniSharp/omnisharp-roslyn/pull/1929))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we only add changes that are visible for consumers as features/bugs and skip things like readme/documentation updates, build script changes or test infra modifications. could you please get rid of them?

Copy link
Contributor Author

@nohwnd nohwnd Oct 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, and done.

CHANGELOG.md Outdated
* Moved most test asset projects to .NET Core 3.1 (PR: [#1968](https://github.com/OmniSharp/omnisharp-roslyn/pull/1968))
* Upgraded to SDK 3.1.402 (PR: [#1966](https://github.com/OmniSharp/omnisharp-roslyn/pull/1966))
* OmniSharp.Path can only be set in user settings (PR: [#1946](https://github.com/OmniSharp/omnisharp-roslyn/pull/1946))
* Adds support for /completion and /completion/resolve endpoints for Cake. (PR: [#1944](https://github.com/OmniSharp/omnisharp-roslyn/pull/1944))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is duplicate

Copy link
Contributor Author

@nohwnd nohwnd Oct 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see what this was duplicate of, because before pushing the first commit I searched the file for each PR id, and did not find any duplicates. Hopefully with the current update the problem is solved.

Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@filipw filipw merged commit 5b95432 into OmniSharp:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants