Make sure we include msbuild 16.3 in Linux distro #1616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipw
requested review from
david-driscoll,
rchande,
bjorkstromm and
akshita31
|
I also asked the users to test these changes and they confirm it fixes things on Linux 🤞 dotnet/vscode-csharp#3290 (comment) |
david-driscoll
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should finally allow us to close the famous issue dotnet/vscode-csharp#3290
This is a follow up to #1606 which fixed the problem on Windows (confirmed by users) and follow up to #1607 which fixed the problem on Mac (also confirmed by users.
We still had the issue on Linux even though I wasn't able to initially reproduce it locally. Turns out, when we run on Azure DevOps we have Mono 6.0.0 (MSBuild 16.3) and Mono 6.4.0 (MSBuild 16.3) side by side and we copied from a wrong place... 😇 Also changed the distro from stable-xenial to vs-xenial.