-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roslyn 3.4 #1597
Roslyn 3.4 #1597
Conversation
can we please merge #1596 first? i'd like to have a separate commit on master on 3.3.1 just in case we want to go back at any point |
@filipw Sorry, didn't see that PR. Mind we we just supersede it with this one (given that this is a later version)? |
can we not merge that other PR first and just publish a release? then we'd have an OmniSharp release based on 3.3.1 which matches the latest VS preview then we merge this PR to get one onto 3.4, I think that would be most desirable course of action |
From the C# extension side we're likely going to try to align with .Net Core 3.1 preview 1, which this build covers, in the next 2 weeks. I doubt we'll ship another release sooner than that. Does that make sense? |
shouldn't we wait for a later 3.4 build then? |
actually we can update again at any point - thanks |
@filipw Thanks for accommodating us :) |
No description provided.