Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roslyn from Dev16.2p2 #1511

Merged
merged 5 commits into from
May 31, 2019
Merged

Roslyn from Dev16.2p2 #1511

merged 5 commits into from
May 31, 2019

Conversation

rchande
Copy link

@rchande rchande commented May 31, 2019

No description provided.

@rchande rchande requested review from filipw and akshita31 and removed request for filipw May 31, 2019 16:44
Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@filipw
Copy link
Member

filipw commented May 31, 2019

thanks!

@@ -119,9 +119,7 @@ public static NullableContextOptions ToNullableContextOptions(string propertyVal
{
case "disable": return NullableContextOptions.Disable;
case "enable": return NullableContextOptions.Enable;
case "safeonly": return NullableContextOptions.SafeOnly;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh I didn't realize LDM decided to drop this 🧐 dotnet/roslyn#35408

@filipw filipw merged commit ef40043 into OmniSharp:master May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants