Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds snippets support in LSP mode. #1422

Merged
merged 10 commits into from
Jun 23, 2019
Merged

Adds snippets support in LSP mode. #1422

merged 10 commits into from
Jun 23, 2019

Conversation

demelev
Copy link
Contributor

@demelev demelev commented Mar 19, 2019

No description provided.

bjorkstromm
bjorkstromm requested changes Mar 19, 2019
View reviewed changes
Copy link
Member

@bjorkstromm bjorkstromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Some minor cosmetic changes, otherwise LGTM 👍

src/OmniSharp.LanguageServerProtocol/Handlers/CompletionHandler.cs Outdated Show resolved Hide resolved
src/OmniSharp.LanguageServerProtocol/Handlers/CompletionHandler.cs Outdated Show resolved Hide resolved
bjorkstromm
bjorkstromm requested changes Mar 19, 2019
View reviewed changes
Copy link
Member

@bjorkstromm bjorkstromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think we should add a null check to the compatibility.

src/OmniSharp.LanguageServerProtocol/Handlers/CompletionHandler.cs Outdated Show resolved Hide resolved
bjorkstromm
bjorkstromm approved these changes Apr 2, 2019
View reviewed changes
Copy link
Member

@bjorkstromm bjorkstromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bjorkstromm
Copy link
Member

@david-driscoll could you also have a look? Thanks!

@david-driscoll david-driscoll merged commit 760ce5e into OmniSharp:master Jun 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorkstromm bjorkstromm bjorkstromm approved these changes

@filipw filipw filipw approved these changes

@david-driscoll david-driscoll david-driscoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@demelev @bjorkstromm @david-driscoll @filipw