support extern alias and add unit test #1409
Conversation
| @@ -233,8 +238,13 @@ public static ProjectData Create(MSB.Execution.ProjectInstance projectInstance) | |||
| { | |||
| references.Add(fullPath); | |||
| } | |||
| var aliases = referencePathItem.GetMetadataValue("Aliases"); | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
add MetadataNames.Aliases = nameof(Aliases), thanks.
| @@ -104,5 +104,25 @@ public async Task NetStandardAndNetCoreApp_has_correct_property_values() | |||
| Assert.Equal("AnyCPU", projectFileInfo.Platform); | |||
| } | |||
| } | |||
|
|
|||
| [Fact] | |||
| public async Task ExternAlias() | |||
There was a problem hiding this comment.
this test is failing at the moment
There was a problem hiding this comment.
forget to add test assets to build.json, now fixed.
|
CI test was failed, I will fix it |
|
I'm using the latest version of VS Code and make the |
|
you can see the test project file here https://github.com/OmniSharp/omnisharp-roslyn/pull/1409/files#diff-2d3349e50030a4adcbf62d5602dcf874 |
|
There is my sample -> https://github.com/seanmars/omnisharp-roslyn-alias-test It's fine to build, but in vs code always got error information like below image. |
This PR will fix project compilation error using
extern alias.related on dotnet/vscode-csharp#2342
Aliasesdescription can be referred in the following links.