Make adding transient documents more reliable. #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prior to this change there were times when a transient document had not been fully removed from the buffer manager's list tracking before trying to add it again. aspnet/Razor.VSCode#214
rchande
approved these changes
Nov 12, 2018
filipw
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change there were times when a transient document had not been fully removed from the buffer manager's list tracking before trying to add it again.
I initially based this branch off of the
v1.32.6tag but looks like I can't represent that in the PR.@rchande @akshita31 For a mid-november patch release would we grab everything from master in omnisharp-roslyn or would we build a separate branch? Either way, this can go into either one, just want to follow the same guidelines that you have always used.
Also, I and @ajaybhargavb tried this out locally and couldn't reproduce the exceptions.
aspnet/Razor.VSCode#214