Added attribute span property for fileMemberElement #1075
Conversation
|
Omnisharp-vscode side : dotnet/vscode-csharp#1938 |
| @@ -9,6 +9,10 @@ public class FileMemberElement : IComparable<FileMemberElement> | |||
|
|
|||
| public QuickFix Location { get; set; } | |||
|
|
|||
| public int AttributeSpanStart { get; set; } | |||
There was a problem hiding this comment.
Can we make these some kind of range or span type?
There was a problem hiding this comment.
@rchande We could pass both AttributeSpanStart and AttributeSpanEnd in a Span type class. But in that case we will also have to define this class in protocol.ts in omnisharp-vscode. Should that be done ?
There was a problem hiding this comment.
Protocol.ts defines a range type: https://github.com/OmniSharp/omnisharp-vscode/blob/master/src/omnisharp/protocol.ts#L450
There was a problem hiding this comment.
@rchande Yes it does, but the range has the start and end as Point type. And I couldn't spot a function in omnisharp-roslyn that converts from a span to range
Issue : dotnet/vscode-csharp#429
Added properties to contain the attribute span in a file member element, which will be used by the editor to display the "# of references" before the attributes.