Return a diagnostic's Id from /codecheck calls #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DustinCampbell
approved these changes
Nov 27, 2017
|
@srivatsn : Did you close and re-open to try and kick CI? Note that your branch can't be merged without updating it with master. |
|
Yes CI seemed to have timeout running tests. Merged with master now. |
|
Travis OSX builds can be... sluggish during U.S. business hours and generally time out around 45 minutes. If that happens again, let me know and I'll kick that particular build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that when displaying an error we can show the error code as well.
@DustinCampbell