Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intellisense not showing methods from the Base class in Signature Help #1030

Merged
merged 17 commits into from
Dec 8, 2017
Merged

Intellisense not showing methods from the Base class in Signature Help #1030

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
30c5092
Added code to check for the methods in the base classes
akshita31 Nov 23, 2017
de3de6a
Made changes to avoid the classes in System Namespace and added test
akshita31 Nov 23, 2017
ef0352a
Changed local variables to lowerCase and added spacing
akshita31 Nov 23, 2017
eff068d
Test for Inaccesible Methods
akshita31 Nov 27, 2017
cf8f790
Using GetMemberGroup
akshita31 Nov 27, 2017
6362fda
Unnecessary using removed
akshita31 Nov 27, 2017
997d104
Test for Overloaded Extension Methods
akshita31 Nov 27, 2017
41d4d2c
Changes for handling Extension Methods
akshita31 Nov 28, 2017
2c0bc6f
Added test for Access Modifiers
akshita31 Nov 28, 2017
9cb58b4
Changes for static invocations
akshita31 Nov 28, 2017
07cee28
Removed unnecessary Blank Lines and Renamed IsInStaticContext
akshita31 Nov 29, 2017
29b3803
Added copyright and todo
akshita31 Nov 29, 2017
2e1e0a0
Merge branch 'master' into base_class_func
akshita31 Nov 29, 2017
cda2c28
Changed Language Version
akshita31 Nov 29, 2017
a13a6b0
Added Attribution
akshita31 Nov 30, 2017
17f52cf
Corrected spelling
akshita31 Dec 7, 2017
fbc4c5f
Merge branch 'master' into base_class_func
DustinCampbell Dec 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/OmniSharp.Roslyn.CSharp/Services/Signatures/CheckStaticInvocation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
using System;
// Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might add a comment for where this was copied from.


using System;
using System.Collections.Generic;
using System.Linq;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort usings. System namespaces go first. (Note that this is a setting in Visual Studio)

using Microsoft.CodeAnalysis;
Expand All @@ -7,6 +9,7 @@

namespace OmniSharp.Roslyn.CSharp.Services.Signatures
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a line between the using directives and the namespace.

{
//TO DO: Reomove this class once a public API for Signature Help from Roslyn is available
Copy link

@rchande rchande Dec 7, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reomove -> Remove

internal static class CheckForStaticExtension
{
public static bool IsInStaticContext(this SyntaxNode node)
Expand Down