Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShowMessageRequestClientCapabilities should implement ICapability #1117

Closed
chrissimon-au opened this issue Nov 19, 2023 · 0 comments · Fixed by #1118
Closed

ShowMessageRequestClientCapabilities should implement ICapability #1117

chrissimon-au opened this issue Nov 19, 2023 · 0 comments · Fixed by #1118

Comments

@chrissimon-au
Copy link
Contributor

When attempting to use the LanguageServerTestBase to construct a LanguageClient for e2e testing of my language server, I'd like to test different scenarios for the client supporting message requests and not.

Unfortunately, ShowMessageRequestClientCapabilities doesn't implement ICapability, so when trying to add it to the client options with WithCapability it fails due to the type requirement.

This seems like a simple fix, so I'll be linking a PR shortly.
chrissimon-au added a commit to chrissimon-au/csharp-language-server-protocol that referenced this issue Nov 19, 2023
@chrissimon-au
fix: add ICapability to ShowMessageRequestClientCapabilities. Fixes O…
6837d3b 
…mniSharp#1117
@chrissimon-au chrissimon-au mentioned this issue Nov 19, 2023
Merged
JoeRobich added a commit that referenced this issue Nov 20, 2023
@JoeRobich
Merge pull request #1118 from chrissimon-au/fix/showMessageRequestCli…
c3e4e8a 
…entCapability

Add ICapability to ShowMessageRequestClientCapabilities. Fixes #1117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@chrissimon-au