Skip to content

Commit

Permalink
Remove unused crate dependencies (apache#14827)
Browse files Browse the repository at this point in the history
* Enable 'extended tests' on forks

Allow contributors to run extended tests workflow if they wish to, just
like they can run rust tests workflow on their forks, before opening a
PR to DataFusion. GitHub allows enabling/disabling workflows in the web
UI without needing to change workflow yaml file.

* Remove unused crate dependencies

Found by `cargo udeps`. Unfortunately there were false positives too.

* one on workspace level
  • Loading branch information
findepi authored Feb 23, 2025
1 parent 1c54b38 commit c0b749d
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 11 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/extended.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,13 @@ concurrency:

# https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#running-your-pull_request-workflow-when-a-pull-request-merges
#
# These jobs only run on the `main` branch as they are time consuming
# These jobs are not run as part of PR checks as they are time-consuming
# and should not fail often.
#
# We still run them as they provide important coverage to ensure correctness
# in the (very rare) event of a hash failure or sqlite library query failure.
on:
# Run on all commits to main
push:
branches:
- main

jobs:
# Check crate compiles and base cargo check passes
Expand Down
3 changes: 0 additions & 3 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,6 @@ pbjson = { version = "0.7.0" }
pbjson-types = "0.7"
# Should match arrow-flight's version of prost.
prost = "0.13.1"
prost-derive = "0.13.1"
rand = "0.8.5"
recursive = "0.1.1"
regex = "1.8"
Expand Down
1 change: 0 additions & 1 deletion datafusion/physical-optimizer/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ recursive_protection = ["dep:recursive"]
[dependencies]
arrow = { workspace = true }
datafusion-common = { workspace = true, default-features = true }
datafusion-datasource = { workspace = true }
datafusion-execution = { workspace = true }
datafusion-expr = { workspace = true }
datafusion-expr-common = { workspace = true, default-features = true }
Expand Down
2 changes: 0 additions & 2 deletions datafusion/wasmtest/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,12 @@ datafusion-common = { workspace = true, default-features = true }
datafusion-execution = { workspace = true }
datafusion-expr = { workspace = true }
datafusion-optimizer = { workspace = true, default-features = true }
datafusion-physical-expr = { workspace = true, default-features = true }
datafusion-physical-plan = { workspace = true }
datafusion-sql = { workspace = true }
# getrandom must be compiled with js feature
getrandom = { version = "0.2.8", features = ["js"] }

wasm-bindgen = "0.2.99"
wasm-bindgen-futures = "0.4.49"

[dev-dependencies]
tokio = { workspace = true }
Expand Down

0 comments on commit c0b749d

Please sign in to comment.