Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing number of extruders permanently affects the number of filament manager tools #79

Closed
techfreek opened this issue Oct 13, 2021 · 2 comments

Comments

@techfreek
Copy link

Describe the bug
As part of testing an integration of this plugin into OctoScreen (Z-Bolt/OctoScreen#315) I modified my OctoPrint settings to say I had 2 extruders to see what the UI looked like. I saw the results, was content, and changed OctoPrint back to 1 extruder. Ever since, I've seen that the "plugin/filamentmanager/selections" endpoint still returns 2 tools. This is even after rebooting and even upgrading to OctoPrint 1.7

Steps to reproduce

  1. Open Settings
  2. Click on Printer Profiles
  3. Edit the active Profile
  4. Click on Hotend & Extruder
  5. Change to 2 extruders
  6. Save
  7. Check the output of "plugin/filamentmanager/selections"
  8. Repeat steps 1-4
  9. Change extruders to 1
  10. Save
  11. See that "plugin/filamentmanager/selections" still returns 2 tools

To check the output of the "plugin/filamentmanager/selections" endpoint, I used chrome dev tools to "Copy as cURL" and run that.

Expected behavior
"plugin/filamentmanager/selections" returns the correct number of tools

Did the same happen when all other 3rd party plugins are disabled?
Have not tested

Log file
No logs related to filament manager

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

@OllisGit OllisGit added the status: inNextRelease Will be implemented/fixed in next release label Oct 17, 2021
OllisGit added a commit that referenced this issue Oct 17, 2021
- PR #77 Show errors when database connection test fails. Thx @techfreek
- E #72 French translation. Thx @LeBress
- B #66 assign temp.offset after connecting the printer
- B #79 selections-API return only the max numbers of tools
@OllisGit OllisGit added status: waitingForTestFeedback and removed status: inNextRelease Will be implemented/fixed in next release labels Oct 17, 2021
@OllisGit
Copy link
Owner

Hi @techfreek,
new version 1.9.0 now only response with the max tool count selection.

Please test and give feedback
Olli

@techfreek
Copy link
Author

Thanks @OllisGit ! Looks like it is is correctly returning 1 selection now. Looks like the only remaining issue is in my WIP integration for OctoScreen. I'll work on fixing that, but this bug can be called fixed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants