Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update/add remote offsets #296

Merged
merged 12 commits into from
Apr 29, 2022
Merged

Update/add remote offsets #296

merged 12 commits into from
Apr 29, 2022

Conversation

JKohlman
Copy link
Collaborator

@JKohlman JKohlman commented Apr 1, 2022 •
edited
Loading

Don't merge until we get offset json's figured out!

Todo:

  • Fix for x64 support (since broadcast version is the same for x86 and x64)
  • Add error for fetch fail
  • Look into updating offsets automatically using github actions (can be done after the merge as well)

@JKohlman JKohlman requested a review from OhMyGuus April 1, 2022 23:41
@github-actions
Copy link

github-actions bot commented Apr 1, 2022 •
edited
Loading

Download the artifacts for this pull request:

@OhMyGuus
Copy link
Owner

Todo:

  • Fix for x64 support (since broadcast version is the same for x86 and x64)
  • Looking into updating it automatic using github actions (can be done after the merge as well)

@JKohlman
Copy link
Collaborator Author

JKohlman commented Apr 28, 2022 •
edited
Loading

Also todo:

  • Add error for fetch fail

@JKohlman JKohlman marked this pull request as ready for review April 28, 2022 04:15
@JKohlman
Copy link
Collaborator Author

A bit of review and testing and it should be good to merge. I think the only necessary changes would be in the offsets repo now.

OhMyGuus
OhMyGuus approved these changes Apr 28, 2022
View reviewed changes
Copy link
Owner

@OhMyGuus OhMyGuus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) time to merge

@OhMyGuus OhMyGuus merged commit 0b20899 into OhMyGuus:nightly Apr 29, 2022
@JKohlman JKohlman deleted the update/AddRemoteOffsets branch June 17, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OhMyGuus OhMyGuus OhMyGuus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JKohlman @OhMyGuus