fix: no detailed error message in AAD app actions #8737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #8737 +/- ##
==========================================
- Coverage 79.02% 79.00% -0.02%
==========================================
Files 604 604
Lines 41588 41588
Branches 8221 8221
==========================================
- Hits 32863 32857 -6
Misses 5436 5436
- Partials 3289 3295 +6
|
blackchoey
requested review from
jayzhang,
xzf0587,
hund030 and
LongOddCode
as code owners
blackchoey
commented
May 18, 2023
| @@ -327,7 +327,9 @@ describe("aadAppCreate", async () => { | |||
| expect(result.result._unsafeUnwrapErr()) | |||
| .is.instanceOf(UnhandledUserError) | |||
| .and.has.property("message") | |||
| .and.contains("An unexpected error has occurred while performing the aadApp/create task"); | |||
| .and.equals( | |||
| 'An unexpected error has occurred while performing the aadApp/create task. {"error":{"code":"Request_BadRequest","message":"Invalid value specified for property \'displayName\' of resource \'Application\'."}}' | |||
There was a problem hiding this comment.
@jidddddd can you help review the new message? The API response various in different situation, so we put the raw response here to avoid missing useful information.
blackchoey
commented
May 18, 2023
| @@ -327,7 +327,9 @@ describe("aadAppCreate", async () => { | |||
| expect(result.result._unsafeUnwrapErr()) | |||
| .is.instanceOf(UnhandledUserError) | |||
| .and.has.property("message") | |||
| .and.contains("An unexpected error has occurred while performing the aadApp/create task"); | |||
| .and.equals( | |||
| 'An unexpected error has occurred while performing the aadApp/create task. {"error":{"code":"Request_BadRequest","message":"Invalid value specified for property \'displayName\' of resource \'Application\'."}}' | |||
There was a problem hiding this comment.
@jayzhang Please also help review the new message in case it violates the error message practices.
jidddddd
approved these changes
May 19, 2023
jayzhang
approved these changes
May 19, 2023
xzf0587
approved these changes
May 19, 2023
blackchoey
added a commit
that referenced
this pull request
Jun 2, 2023
adashen
added a commit
that referenced
this pull request
Jun 5, 2023
…or-aad fix: no detailed error message in AAD app actions (#8737)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: https://dev.azure.com/msazure/Microsoft%20Teams%20Extensibility/_workitems/edit/23074298
The message in axios error only includes the status code, which can not help users fix the actual problem. Return the response in axiosError.response.data to tell users more details about the error.
This can improve the troubleshooting experience in issue #8733