fix: upgrade workflow bot template based on Teams store policy #12119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MuyangAmigo Please help reviewing the content, thanks. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #12119 +/- ##
========================================
Coverage 89.45% 89.45%
========================================
Files 571 571
Lines 33583 33583
Branches 6483 6636 +153
========================================
Hits 30043 30043
Misses 1583 1583
Partials 1957 1957 |
yukun-dong
previously approved these changes
Jul 31, 2024
dooriya
reviewed
Jul 31, 2024
|
|
||
| public IEnumerable<ITriggerPattern> TriggerPatterns => new List<ITriggerPattern> | ||
| { | ||
| // Used to trigger the command handler if the command text contains 'helloWorld' |
There was a problem hiding this comment.
Need to update the code comment here to consistent with the RegExp.
There was a problem hiding this comment.
Thanks, updated.
dooriya
approved these changes
Jul 31, 2024
eriolchan
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade workflow bot template (js ts csharp version)
Based on Teams Store validation guidelines (https://learn.microsoft.com/en-us/microsoftteams/platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines)
Reference
command bot
All commands that your bot supports must work correctly, including generic commands such as Hi, Hello, and Help. [Mandatory Fix]
Bot commands mustn't lead a user to a dead end, the commands must always provide a way forward. [Mandatory Fix]
Bots must always provide a valid response to a user input even if the input is irrelevant or improper. [Mandatory Fix]
Bots must provide a valid response to invalid user commands. Bots mustn't dead-end the user or display an error if a user sends an invalid bot command. [Mandatory Fix]
Welcome message must auto trigger on app install in a personal scope. If the bot doesn't send a welcome message in a personal scope, the user is lead to a dead-end. If the app doesn't include a complex configuration workflow, it's optional for the developer to trigger a welcome message in the channel or group chat scope. [Mandatory Fix]
Welcome message mustn't dead-end the user. Welcome message must include the value offered by the bot to the users who installed the bot in channel, how to configure the bot, and briefly describe all supported bot commands. You can display the welcome message using an Adaptive Card with buttons for better usability. [Mandatory Fix]