perf(spec-parser): optimize "None Auth", special media type, AC card gen

packages/fx-core/resource/package.nls.json

@@ -255,9 +255,9 @@
   "core.TabSPFxOption.detailNew": "Build UI with SharePoint Framework",
   "core.TabNonSso.label": "Basic Tab",
   "core.TabNonSso.detail": "A simple implementation of a web app that's ready to customize",
-  "core.copilotPlugin.api.noAuth": "None auth",
-  "core.copilotPlugin.api.apiKeyAuth": "API key auth(Bearer token auth)",
-  "core.copilotPlugin.api.oauth": "OAuth(Auth code flow)",
+  "core.copilotPlugin.api.noAuth": "No authentication",
+  "core.copilotPlugin.api.apiKeyAuth": "API Key authentication(Bearer token authentication)",
+  "core.copilotPlugin.api.oauth": "OAuth(Authorization code flow)",
   "core.copilotPlugin.validate.apiSpec.summary": "Teams Toolkit has checked your OpenAPI description document:\n\nSummary:\n%s.\n%s\n%s",
   "core.copilotPlugin.validate.summary.validate.failed": "%s failed",
   "core.copilotPlugin.validate.summary.validate.warning": "%s warning",

packages/fx-core/tests/component/coordinator/coordinator.create.test.ts

@@ -884,7 +884,7 @@ const V3Version = MetadataV3.projectVersion;
       assert.isTrue(res.isErr() && res.error.name === "test");
     });
 
-    it("create API Plugin with none auth (feature flag enabled)", async () => {
+    it("create API Plugin with No authentication (feature flag enabled)", async () => {
       const v3ctx = createContext();
       v3ctx.userInteraction = new MockedUserInteraction();
 

packages/fx-core/tests/component/generator/copilotGenerator.test.ts

@@ -146,7 +146,7 @@ describe("OpenAPISpecGenerator", function () {
     assert.equal(downloadTemplate.args[0][2], "copilot-plugin-existing-api");
   });
 
-  it("success with api key auth", async function () {
+  it("success with API Key authentication", async function () {
     const inputs: Inputs = {
       platform: Platform.VSCode,
       projectPath: "path",

packages/fx-core/tests/question/create.test.ts

@@ -249,7 +249,7 @@ describe("scaffold question", () => {
       ]);
     });
 
-    it("traverse in vscode me from new api (none auth)", async () => {
+    it("traverse in vscode me from new api (No authentication)", async () => {
       const inputs: Inputs = {
         platform: Platform.VSCode,
       };
@@ -1580,7 +1580,7 @@ describe("scaffold question", () => {
         ]);
       });
 
-      it("traverse in vscode Copilot Plugin from new API with api key auth", async () => {
+      it("traverse in vscode Copilot Plugin from new API with API Key authentication", async () => {
         const inputs: Inputs = {
           platform: Platform.VSCode,
         };
@@ -2380,7 +2380,7 @@ describe("scaffold question", () => {
             {
               id: "get operation1",
               label: "get operation1",
-              detail: "API key auth(Bearer token auth)",
+              detail: "API Key authentication(Bearer token authentication)",
               groupName: "GET",
               data: {
                 authName: "bearerAuth",
@@ -2391,7 +2391,7 @@ describe("scaffold question", () => {
             {
               id: "get operation2",
               label: "get operation2",
-              detail: "None auth",
+              detail: "No authentication",
               groupName: "GET",
               data: {
                 serverUrl: "https://server2",
@@ -2400,7 +2400,7 @@ describe("scaffold question", () => {
             {
               id: "get operation3",
               label: "get operation3",
-              detail: "OAuth(Auth code flow)",
+              detail: "OAuth(Authorization code flow)",
               groupName: "GET",
               data: {
                 serverUrl: "https://server",
@@ -2466,7 +2466,7 @@ describe("scaffold question", () => {
             {
               id: "get operation1",
               label: "get operation1",
-              detail: "API key auth(Bearer token auth)",
+              detail: "API Key authentication(Bearer token authentication)",
               groupName: "GET",
               data: {
                 authName: "bearerAuth",
@@ -2477,7 +2477,7 @@ describe("scaffold question", () => {
             {
               id: "get operation2",
               label: "get operation2",
-              detail: "None auth",
+              detail: "No authentication",
               groupName: "GET",
               data: {
                 serverUrl: "https://server2",
@@ -2673,7 +2673,7 @@ describe("scaffold question", () => {
             {
               id: "GET /store/order",
               label: "GET /store/order",
-              detail: "None auth",
+              detail: "No authentication",
               groupName: "GET",
               data: {
                 serverUrl: "https://server2",
@@ -2795,7 +2795,7 @@ describe("scaffold question", () => {
                 serverUrl: "https://server",
               },
               groupName: "GET",
-              detail: "None auth",
+              detail: "No authentication",
               id: "GET /user/{userId}",
               label: "GET /user/{userId}",
             },

packages/spec-parser/src/utils.ts

@@ -125,16 +125,21 @@ export class Utils {
     for (const code of ConstantString.ResponseCodeFor20X) {
       const responseObject = operationObject?.responses?.[code] as OpenAPIV3.ResponseObject;
 
-      if (responseObject?.content?.["application/json"]) {
-        multipleMediaType = false;
-        json = responseObject.content["application/json"];
-        if (Utils.containMultipleMediaTypes(responseObject)) {
-          multipleMediaType = true;
-          if (!allowMultipleMediaType) {
-            json = {};
+      if (responseObject?.content) {
+        for (const contentType of Object.keys(responseObject.content)) {
+          // json media type can also be "application/json; charset=utf-8"
+          if (contentType.indexOf("application/json") >= 0) {
+            multipleMediaType = false;
+            json = responseObject.content[contentType];
+            if (Utils.containMultipleMediaTypes(responseObject)) {
+              multipleMediaType = true;
+              if (!allowMultipleMediaType) {
+                json = {};
+              }
+            } else {
+              return { json, multipleMediaType };
+            }
           }
-        } else {
-          break;
         }
       }
     }
@@ -479,10 +484,12 @@ export class Utils {
 
         currentCount += items.length;
       } else {
-        if (currentCount < maxCount) {
-          result.push(element);
-          currentCount++;
-        }
+        result.push(element);
+        currentCount++;
+      }
+
+      if (currentCount >= maxCount) {
+        break;
       }
     }