Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: launch desktop client #11750

Merged
merged 5 commits into from
Jun 4, 2024
Merged

feat: launch desktop client #11750

merged 5 commits into from
Jun 4, 2024

Conversation

xiaolang124
Copy link
Contributor

@xiaolang124 xiaolang124 commented May 31, 2024 •
edited
Loading

@xiaolang124 xiaolang124 changed the title Feat/launch desktop client feat: launch desktop client May 31, 2024
@codecov Codecov
Copy link

codecov bot commented May 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.44%. Comparing base (7f61fc3) to head (b0ff516).
Report is 1 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##              dev   #11750    +/-   ##
========================================
  Coverage   88.43%   88.44%            
========================================
  Files         530      530            
  Lines       32447    32449     +2     
  Branches     6332     6459   +127     
========================================
+ Hits        28696    28698     +2     
  Misses       1817     1817            
  Partials     1934     1934
Files Coverage Δ
packages/fx-core/src/component/local/constants.ts 100.00% <ø> (ø)
packages/vscode-extension/src/error.ts 100.00% <100.00%> (ø)
...code-extension/src/telemetry/extTelemetryEvents.ts 100.00% <100.00%> (ø)

@xiaolang124 xiaolang124 marked this pull request as ready for review June 3, 2024 02:12
@xiaolang124 xiaolang124 requested a review from swatDong June 3, 2024 06:34
@xiaolang124 xiaolang124 merged commit 05361c3 into dev Jun 4, 2024
20 checks passed
@xiaolang124 xiaolang124 deleted the feat/launch-desktop-client branch June 4, 2024 05:45
@github-actions github-actions bot mentioned this pull request Jun 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tecton tecton tecton approved these changes

@swatDong swatDong swatDong approved these changes

@supkasar supkasar supkasar approved these changes

@kimizhu kimizhu Awaiting requested review from kimizhu kimizhu is a code owner

@kuojianlu kuojianlu Awaiting requested review from kuojianlu kuojianlu is a code owner

@a1exwang a1exwang Awaiting requested review from a1exwang a1exwang is a code owner

@qinezh qinezh Awaiting requested review from qinezh qinezh is a code owner

@XiaofuHuang XiaofuHuang Awaiting requested review from XiaofuHuang XiaofuHuang is a code owner

@dooriya dooriya Awaiting requested review from dooriya dooriya is a code owner

@timngmsft timngmsft Awaiting requested review from timngmsft timngmsft is a code owner

@sffamily sffamily Awaiting requested review from sffamily sffamily is a code owner

@therealjohn therealjohn Awaiting requested review from therealjohn therealjohn is a code owner

@1openwindow 1openwindow Awaiting requested review from 1openwindow 1openwindow is a code owner

@HuihuiWu-Microsoft HuihuiWu-Microsoft Awaiting requested review from HuihuiWu-Microsoft HuihuiWu-Microsoft is a code owner

@nliu-ms nliu-ms Awaiting requested review from nliu-ms nliu-ms is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiaolang124 @tecton @swatDong @supkasar