Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cli naming in string #11656

Merged
merged 1 commit into from
May 21, 2024
Merged

fix: cli naming in string #11656

merged 1 commit into from
May 21, 2024

Conversation

jayzhang
Copy link
Member

@jayzhang jayzhang marked this pull request as ready for review May 20, 2024 02:44
@codecov Codecov
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (20d61ba) to head (d307bf8).
Report is 1 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##              dev   #11656    +/-   ##
========================================
  Coverage   88.41%   88.41%            
========================================
  Files         535      535            
  Lines       32632    32632            
  Branches     6287     6410   +123     
========================================
  Hits        28853    28853            
  Misses       1837     1837            
  Partials     1942     1942

@jayzhang jayzhang merged commit 537ee19 into dev May 21, 2024
20 checks passed
@jayzhang jayzhang deleted the huajie/clinaming-string branch May 21, 2024 10:19
@github-actions github-actions bot mentioned this pull request Jun 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffamily sffamily sffamily approved these changes

@timngmsft timngmsft Awaiting requested review from timngmsft timngmsft is a code owner

@therealjohn therealjohn Awaiting requested review from therealjohn therealjohn is a code owner

@supkasar supkasar Awaiting requested review from supkasar supkasar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayzhang @sffamily