Skip to content
This repository has been archived by the owner on Jun 18, 2024. It is now read-only.

Fix SASS mixin for input-placeholders. #772

Merged
merged 2 commits into from
Aug 15, 2016

Conversation

leddie24
Copy link
Contributor

See http://www.codechewing.com/library/create-sass-mixin-for-styling-placeholders-css/ for information.

It’s important that each vendor’s style is contained within a separate selector block of their own. If we were to merge the selectors together, then a browser which doesn’t understand one of the selectors will actually invalidate the entire line of selectors.

@msftclas
Copy link

Hi @leddie24, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@mikewheaton
Copy link
Contributor

mikewheaton commented Aug 15, 2016

Approved

Approved with PullApprove

1 similar comment
@gokunymbus
Copy link
Contributor

gokunymbus commented Aug 15, 2016

Approved

Approved with PullApprove

@leddie24 leddie24 merged commit 6e99721 into master Aug 15, 2016
@leddie24 leddie24 deleted the leddie24/fix-sass-input-placeholder-mixin branch August 15, 2016 22:59
@mikewheaton mikewheaton added this to the 3.1.0 milestone Aug 23, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants