Skip to content
This repository has been archived by the owner on Jun 18, 2024. It is now read-only.

Variable cdn path for icons, as per fonts #1144

Merged
merged 6 commits into from
Oct 4, 2018
Merged

Variable cdn path for icons, as per fonts #1144

merged 6 commits into from
Oct 4, 2018

Conversation

thornyweb
Copy link
Contributor

Create and use variable for icons path rather than being hard coded.

Also change a couple of hard coded font paths to use the cdn variable that already exists.

@msftclas
Copy link

msftclas commented Sep 27, 2018

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@mikewheaton mikewheaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @thornyweb! Looks great to me.

@mikewheaton
Copy link
Contributor

mikewheaton commented Sep 28, 2018

The build issue is caused by the Travis config specifying an outdated version of Node. This has been fixed on the Fluent branch (see this commit) but not yet on master. I'll make a separate PR to fix it so we can get a clean build here.

@thornyweb
Copy link
Contributor Author

Thanks @mikewheaton

@mikewheaton mikewheaton added this to the 9.7.0 milestone Oct 4, 2018
@mikewheaton mikewheaton merged commit 143977d into OfficeDev:master Oct 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants