This repository has been archived by the owner on Jun 18, 2024. It is now read-only.
Update icons to version 2.58 #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynamemi
approved these changes
Dec 4, 2017
mikewheaton
reviewed
Dec 5, 2017
| @@ -653,7 +657,6 @@ | |||
| { "name": "Hospital", "unicode": "E91D" }, | |||
| { "name": "Hotel", "unicode": "E824" }, | |||
| { "name": "HourGlass", "unicode": "EA03" }, | |||
| { "name": "HumanResources", "unicode": "F240" }, | |||
There was a problem hiding this comment.
This will remove the icon from the documentation, right? That's probably for the best, as we don't have a way to indicate deprecated icons in the documentation and would prefer that no one starts using it now.
There was a problem hiding this comment.
Yeah, removing icons from the JSON will hide them on the site. I think it's the right thing to do in the absence of documenting deprecated icons--though I wonder if we should look into supporting those at some point as well (e.g. with something like deprecated-icons.json or something along those lines).
mikewheaton
approved these changes
Dec 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1073 by updating the icons to version 2.58.
Deprecated
New icons