Skip to content
This repository has been archived by the owner on Jun 18, 2024. It is now read-only.

Layout problem when using the image ListItem component with is-selectable class #100

Closed
ilyalehrman opened this issue Sep 7, 2015 · 3 comments
Closed

Layout problem when using the image ListItem component with is-selectable class #100

ilyalehrman opened this issue Sep 7, 2015 · 3 comments
Assignees
@wdo3650
Labels
bug VSTS

Comments

@ilyalehrman
Copy link

Combining the image ListItem component with the is-selectable class leads to selection checkmark overlap with the image...

2015-09-07_17-09-53
@wdo3650
Copy link
Contributor

wdo3650 commented Sep 8, 2015

Thanks for the issue. We'll look into this.

@wdo3650 wdo3650 self-assigned this Sep 8, 2015
wdo3650 pushed a commit that referenced this issue Sep 8, 2015
Fix for #100. Changed margin-left on image if ListItem is in is-selec…
832a7f1 
…table state.
@wdo3650 wdo3650 mentioned this issue Sep 8, 2015
Merged
wdo3650 added a commit that referenced this issue Sep 9, 2015
@wdo3650
Merge pull request #105 from OfficeDev/v-wido/listitem-image-is-selec…
a82fd8e 
…table-bug

Fix for #100. Changed margin-left on image if is-selectable state
@wdo3650
Copy link
Contributor

wdo3650 commented Sep 9, 2015

This issue has been fixed in the develop branch and we're in the process of merging it into master. Thanks again for letting us know about the issue.

@wdo3650 wdo3650 closed this as completed Sep 9, 2015
@wdo3650 wdo3650 reopened this Sep 9, 2015
@mikewheaton
Copy link
Contributor

This seems to be fixed as of Fabric 1.2.1. See the attempted repro of this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@wdo3650 wdo3650

Labels
bug VSTS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mikewheaton @ericthompson @wdo3650 @ilyalehrman