Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive token bridge addresses on child chain from chain ID #41

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

gvladika
Copy link
Contributor

@gvladika gvladika commented Sep 8, 2023

Add chainId to the L2 salt which is used to derive L2 addresses. This means L2 addresses won't be same across every Orbit chain. Each Orbit chain will have its own set of canonical addresses.

@cla-bot cla-bot bot added the cla-signed label Sep 8, 2023
@gvladika gvladika requested review from gzeoneth and yahgwai September 8, 2023 14:05
Copy link
Member

@gzeoneth gzeoneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gvladika gvladika merged commit ee8c5aa into fee-token-deployer Sep 11, 2023
@gzeoneth gzeoneth deleted the use-chain-id branch July 8, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants