Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Fixes #9

Merged
merged 15 commits into from
Jun 13, 2022
Merged

Multiple Fixes #9

merged 15 commits into from
Jun 13, 2022

Conversation

christopher-besch
Copy link
Member

@christopher-besch christopher-besch commented Jun 8, 2022

@christopher-besch
Copy link
Member Author

The newest version of juxtapose.js has to be used because the undocumented callback doesn't get called on the last release.

@christopher-besch
Copy link
Member Author

Actually the latest release does work, the "latest" release on GitHub is only from 2014 for some reason. So using v.1.2.2 is ok.

@christopher-besch
Copy link
Member Author

@kolibril13, could you take a look at this? The CSS is currently missing so the images are way too large; I'll fix that later.

christopher-besch and others added 2 commits June 13, 2022 11:09
Co-authored-by: Jan-Hendrik Müller <[email protected]>
Co-authored-by: Jan-Hendrik Müller <[email protected]>
@christopher-besch christopher-besch marked this pull request as ready for review June 13, 2022 19:25
Copy link
Member

@kolibril13 kolibril13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot for these changes!
That is a great improvement, and I am especially happy about the fact that the package will be now usable without an internet connection.

Co-authored-by: Jan-Hendrik Müller <[email protected]>
@christopher-besch christopher-besch merged commit 850efc7 into main Jun 13, 2022
@christopher-besch christopher-besch deleted the chris_branch branch June 14, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants