Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First create PiNozCam.md #1285

Merged
merged 4 commits into from
Mar 6, 2024
Merged

First create PiNozCam.md #1285

merged 4 commits into from
Mar 6, 2024

Conversation

DrAlexLiu
Copy link
Contributor

No description provided.

@DrAlexLiu
Copy link
Contributor Author

First create the PiNozCam and publish

Copy link
Contributor

@jneilliii jneilliii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a recommended pi version for handling the AI image processing? Might be a good idea to include that here in the plugin listing.

There are a couple of issues. here needs to match your plugins identifier from setup.py. Change updateplugindemo to pinozcam. Same is true for the id in your plugin listing md file, as well as the filename itself. PiNozCam.md should be named pinozcam.md.

---
layout: plugin

id: PiNozCam
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be pinozcam to match setup.py

@jneilliii
Copy link
Contributor

Couple of other house-keeping items. Delete the folders OctoPrint_PiNozCam.egg-info and pycache, they shouldn't be included in your plugin's repo and are typically added to .gitignore to prevent them from being uploaded.

@jneilliii
Copy link
Contributor

you may also want to include a screenshot of the tab, it's highly recommended.

@DrAlexLiu
Copy link
Contributor Author

Thanks for approval.

@jneilliii jneilliii merged commit f3f6039 into OctoPrint:gh-pages Mar 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants