Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Nozzle-Filament-Validator plugin data to the repo #1281

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

Rylan-Meilutis
Copy link
Contributor

Added Nozzle-Filament-Validator plugin data to the plugin repo

@jneilliii
Copy link
Contributor

You might consider switching your AJAX calls to use https://docs.octoprint.org/en/master/jsclientlib/base.html#OctoPrintClient.simpleApiGet and https://docs.octoprint.org/en/master/jsclientlib/base.html#OctoPrintClient.simpleApiCommand in your js file to avoid issues related to CSR validation. Other than that don't see any issues with merging.

@jneilliii jneilliii merged commit d7a075d into OctoPrint:gh-pages Feb 26, 2024
4 checks passed
@jneilliii
Copy link
Contributor

Another thing I thought of is you might want to implement https://docs.octoprint.org/en/master/modules/printer.html#octoprint.printer.PrinterInterface.job_on_hold in your print started event. I've used this in my BedReady plugin as a real-world example here. It's slightly different because I'm using an @ command to intercept the process, but you should be able to do the same in your event callback.

Rylan-Meilutis added a commit to Rylan-Meilutis/OctoPrint-Nozzle-Filament-Validator that referenced this pull request Feb 26, 2024
@Rylan-Meilutis
Copy link
Contributor Author

Thanks for the suggestions, I implemented the job_on_hold along with the simple_api_command. when I tried implementing the simpleApiGet, it would fail with a 404 on the page load requiring the function to be called again manually with the refresh button. I was able to get around it be waiting for a 1/2 second before initially loading the data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants