-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
override logging format of websocket package to use OpenRVDAS format #415
Comments
This is turning out to be a more subtle bug than I expected. The cached_data_server does have a standard logging format defined, but something in its includes is pre-empting and scuttling it. Still investigating. |
Okay - fixed in the branch. But it looks like there are two "standard" logging formats:
and
If I move us toward one or the other, which do you think is the right one? |
I personally like the one with the log level (the top one). My rational... That said... what does the "20" column represent? |
It's the numeric log level :
'%(asctime)-15sZ',
'%(levelno)s',
'%(levelname)s',
'%(filename)s:%(lineno)d',
'%(message)s',
That format is defined in logger/utils/stderr_logging.py.
…On Fri, Jan 24, 2025 at 5:29 PM Webb Pinner ***@***.***> wrote:
I personally like the one with the log level (the top one).
My rational...
This issue was first raised by SOI who are starting to analyze logs using
3rd-party tools. Having the log level helps to easily classify the nature
of the message (INFO, WARNING, ERROR, CRITICAL, DEBUG).
That said... what does the "20" column represent?
—
Reply to this email directly, view it on GitHub
<#415 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFO7V3XRT45U6PVV4SEP33L2MLSHTAVCNFSM6AAAAABVU6ER3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJTG4YDMNRTGU>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
I vote this move forward using the current format definition as defined in logger/utils/stderr_logging.py. Users can override if needed. |
log format used by cached_data_server.py differs from standard OpenRVDAS log format.
Notice timestamp is removed from some messages.
Request that format be consistent with other OpenRVDAS log messages.
The text was updated successfully, but these errors were encountered: