Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts challenge 8, adds challenge 12 #85

Closed
wants to merge 10 commits into from

Conversation

commjoen
Copy link
Collaborator

First steps for #43
(@bendehaan : where do we want to put the file actually in the container? in var?)
Thank you for submitting a pull request to the WrongSecrets app!

@commjoen commjoen force-pushed the file-in-fs-generated/#43 branch 2 times, most recently from e7eb872 to a04be68 Compare November 29, 2021 12:10
@bendehaan
Copy link
Collaborator

bendehaan commented Nov 29, 2021

@commjoen I think /var/tmp is fine. Nice to have it randomized per version as well.

@commjoen commjoen force-pushed the file-in-fs-generated/#43 branch from f769141 to 6db420c Compare November 30, 2021 05:07
@commjoen
Copy link
Collaborator Author

image

@commjoen commjoen changed the title Draft; WIP First iteration of #43 Reverts challenge 8, adds challenge 12 Nov 30, 2021
@commjoen commjoen requested review from bendehaan and nbaars November 30, 2021 05:55
@commjoen
Copy link
Collaborator Author

based on docker run -p 8080:8080 jeroenwillemsen/addo-example:challenge12-6-no-vault

bendehaan
bendehaan previously approved these changes Nov 30, 2021
@bendehaan bendehaan dismissed their stale review November 30, 2021 07:20

Saw error

@commjoen commjoen closed this Nov 30, 2021
@commjoen
Copy link
Collaborator Author

closed ude to force pushes

@commjoen commjoen deleted the file-in-fs-generated/#43 branch November 30, 2021 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants