Simplified intigration test for K8s in cypress #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shubham-Patel07
changed the title
commjoen
reviewed
Feb 6, 2024
| @@ -0,0 +1,28 @@ | |||
| describe('Challenge7 Tests', () => { | |||
There was a problem hiding this comment.
Can you please copy paste this for challenge 44, 45, 46?
commjoen
requested changes
Feb 6, 2024
There was a problem hiding this comment.
Hi @Shubham-Patel07 this is a muuuch cleaner PR thank you so much!
We are near completion for sure!
Can you please fix the linter findings in https://github.com/OWASP/wrongsecrets/actions/runs/7794288557/job/21256300742?pr=1235#step:13:169. and can you duplicate challenge7test for challenges 44,45,46 please? Then we are good to merge!
Shubham-Patel07
force-pushed
the
fix/Issue1114
branch
from
fcae951 to
26a8f8a
Compare
commjoen
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hallenges
What kind of changes does this PR include?
Analyzed the tests written in java and rewritten in simplified cypress script for the challenges 5,6,7 and 33
Fixes #1114
Checklist: