-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nodemon #161
Add nodemon #161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks a lot @servatj and welcome to the family ^^
I like that you also updated the Readme. 👍
I just re-started the Travis tests. I had some issue too before, like this one that I believe is a false-negative
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@servatj Thanks for the PR and welcome to the project!
About code changes, when I tested it locally by starting the server using npm run dev
, it seems nodemon is detecting changes only in the server.js but not in other js files or template files. Not sure if it was just my machine for some weird reason, but can you please confirm it is working as expected for you for all file types.
@ckarande Thanks for having me! You're totally right I misplaced the nodemon file in test folder, and also i removed the -watch option in package.json so nodemon gets the settings from the config properly. |
@servatj Thanks for the changes. Looks good to me and we are all set to merge this PR. 🎉 |
Awesome! @UlisesGascon Excellent work organizing the PRs with the right release branch. Please feel free to merge the PR when you get a chance. |
Thanks @ckarande !! 👍 |
Adds nodemon as npm script related to the #156 issue
is not in use, let's move to Nodemon as npm script