Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sentinel - support hostname resolve and annonce #1247

Merged
merged 3 commits into from
Feb 28, 2025

fix

ecbf821
Select commit
Loading
Failed to load commit list.
Merged

feat: Sentinel - support hostname resolve and annonce #1247

fix
ecbf821
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 28, 2025 in 0s

34.97% (+4.76%) compared to 60ef5a2

View this Pull Request on Codecov

34.97% (+4.76%) compared to 60ef5a2

Details

Codecov Report

Attention: Patch coverage is 56.09756% with 18 lines in your changes missing coverage. Please review.

Project coverage is 34.97%. Comparing base (60ef5a2) to head (ecbf821).
Report is 49 commits behind head on master.

Files with missing lines Patch % Lines
pkg/k8sutils/redis-sentinel.go 56.09% 15 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1247      +/-   ##
==========================================
+ Coverage   30.20%   34.97%   +4.76%     
==========================================
  Files          55       49       -6     
  Lines        6294     5573     -721     
==========================================
+ Hits         1901     1949      +48     
+ Misses       4200     3452     -748     
+ Partials      193      172      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.