Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configurable operator maxConcurrentReconciles #1242

Merged

Conversation

husnialhamdani
Copy link
Contributor

Description
configurable operator maxConcurrentReconciles: running multiple instances of (Replication, Sentinel, Cluster) will make the reconcile faster without the need to wait one by one processing.

Fixes #ISSUE

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

@husnialhamdani husnialhamdani changed the title Operator concurrency feat: configurable operator maxConcurrentReconciles Feb 18, 2025
@husnialhamdani
Copy link
Contributor Author

Please check and review @drivebyer

@drivebyer
Copy link
Collaborator

Fix the failing checks plz @husnialhamdani

@husnialhamdani
Copy link
Contributor Author

Fix the failing checks plz @husnialhamdani

What's is wrong with the CI/ lint ?
I was trying to check what's wrong, but couldn't find the clue

@drivebyer
Copy link
Collaborator

Try to rebase on master branch firstly @husnialhamdani

@husnialhamdani
Copy link
Contributor Author

Try to rebase on master branch firstly @husnialhamdani

Seems I found the problem, let me fix first

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 42.10526% with 11 lines in your changes missing coverage. Please review.

Project coverage is 28.81%. Comparing base (60ef5a2) to head (4e7b70f).
Report is 46 commits behind head on master.

Files with missing lines Patch % Lines
main.go 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1242      +/-   ##
==========================================
- Coverage   30.20%   28.81%   -1.39%     
==========================================
  Files          55       58       +3     
  Lines        6294     6771     +477     
==========================================
+ Hits         1901     1951      +50     
- Misses       4200     4656     +456     
+ Partials      193      164      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@drivebyer drivebyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drivebyer drivebyer merged commit 6264dae into OT-CONTAINER-KIT:master Feb 18, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants