-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: configurable operator maxConcurrentReconciles #1242
feat: configurable operator maxConcurrentReconciles #1242
Conversation
Please check and review @drivebyer |
Fix the failing checks plz @husnialhamdani |
What's is wrong with the |
Try to rebase on master branch firstly @husnialhamdani |
Signed-off-by: Husni Alhamdani <[email protected]>
Signed-off-by: Husni Alhamdani <[email protected]>
656a8fb
to
db4597d
Compare
Seems I found the problem, let me fix first |
Signed-off-by: Husni Alhamdani <[email protected]>
Signed-off-by: Husni Alhamdani <[email protected]>
Signed-off-by: Husni Alhamdani <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1242 +/- ##
==========================================
- Coverage 30.20% 28.81% -1.39%
==========================================
Files 55 58 +3
Lines 6294 6771 +477
==========================================
+ Hits 1901 1951 +50
- Misses 4200 4656 +456
+ Partials 193 164 -29 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
configurable operator maxConcurrentReconciles: running multiple instances of (Replication, Sentinel, Cluster) will make the reconcile faster without the need to wait one by one processing.
Fixes #ISSUE
Type of change
Checklist
Additional Context