style: Fix implicit-return-value (RET502) & unnecessary-return-none (RET501) #5030
+59
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RET502: Do not implicitly `return None` in function able to return non-`None` value Ruff rule: https://docs.astral.sh/ruff/rules/implicit-return-value/
RET501 [*] Do not explicitly `return None` in function if it is the only possible return value Ruff rule: https://docs.astral.sh/ruff/rules/unnecessary-return-none/
echoix
changed the title
github-actions
bot
added
GUI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RET501: Do not explicitly
return Nonein function if it is the only possible return value (5 changes)RET502: Do not implicitly
return Nonein function able to return non-Nonevalue (about 30 changes)Ruff rules: https://docs.astral.sh/ruff/rules/implicit-return-value/ and https://docs.astral.sh/ruff/rules/unnecessary-return-none/
When a function can return something else than
None, make it clear that a simplereturnis implicitly returningNone. This is what RET502 is about. If the function only returns None, then use implicitreturninstead.