Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI: Fixed star imports in wxdigit.py #4973

Merged
merged 5 commits into from
Jan 27, 2025
Merged

Conversation

arohanajit
Copy link
Contributor

Removed star imports and categorized variables to fix F405

Arohan Ajit added 2 commits January 22, 2025 08:22
@github-actions github-actions bot added GUI wxGUI related Python Related code is in Python labels Jan 22, 2025
gui/wxpython/vdigit/wxdigit.py Outdated Show resolved Hide resolved
gui/wxpython/vdigit/wxdigit.py Outdated Show resolved Hide resolved
gui/wxpython/vdigit/wxdigit.py Show resolved Hide resolved
Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am also getting an error when I start GRASS, because it's trying to import CFUNCTYPE in vedit.py/main.py from wxdigit.py. So I would just remove the CFUNCTYPE import from there.

gui/wxpython/vdigit/wxdigit.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added raster Related to raster data processing module labels Jan 24, 2025
@petrasovaa petrasovaa added this to the 8.5.0 milestone Jan 27, 2025
@petrasovaa petrasovaa merged commit 71f1bce into OSGeo:main Jan 27, 2025
27 checks passed
@neteler
Copy link
Member

neteler commented Jan 27, 2025

@petrasovaa Undesired .DS_Store/ and raster/.DS_Store/ directories came in through this PR.

@echoix
Copy link
Member

echoix commented Jan 27, 2025

@petrasovaa Undesired .DS_Store/ and raster/.DS_Store/ directories came in through this PR.

We don't have that in .gitignore yet? Nor the windows equivalent like Thumbs.db?

Take a look at the CC0-licenced template for windows macOS and Linux for common patterns https://www.toptal.com/developers/gitignore/api/windows,linux,macos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI wxGUI related module Python Related code is in Python raster Related to raster data processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants