Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wxGUI: Improve exception handling specificity in location wizard #4953

Merged
merged 2 commits into from
Jan 18, 2025
Merged

wxGUI: Improve exception handling specificity in location wizard #4953

merged 2 commits into from
Jan 18, 2025

Conversation

arohanajit
Copy link
Contributor

Replace bare exception handling with specific exception types to prevent masking of unexpected errors and improve error reporting.

Changes:

  • Search operations: Add IndexError/ValueError for list unpacking failures
  • Datum parameters: Add ValueError for list item removal
  • EPSG/IAU searches: Add IndexError/ValueError for search result handling
  • Ellipsoid lookups: Add IndexError/ValueError/KeyError for search and dictionary operations
  • EPSG code parsing: Add ValueError for integer conversion

@github-actions github-actions bot added GUI wxGUI related Python Related code is in Python labels Jan 15, 2025
petrasovaa
petrasovaa requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just that small comment

@petrasovaa petrasovaa added this to the 8.5.0 milestone Jan 15, 2025
@echoix echoix merged commit bfcb541 into OSGeo:main Jan 18, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrasovaa petrasovaa petrasovaa approved these changes

Assignees
No one assigned
Labels
GUI wxGUI related Python Related code is in Python
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@arohanajit @petrasovaa @echoix