CI: set the right environment for setup-msys2 and use the provided shell #3709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI builds for the mingw64 env, so actually use it. Otherwise various env vars are missing and PATH is wrong. Use the shell provided by setup-msys2 instead of calling bash directly, no need to hardcode paths then.
echoix
reviewed
May 14, 2024
echoix
approved these changes
May 14, 2024
|
@lazka Thank you! |
|
np. I doesn't change much, but it should make things closer to when you build it manually on Windows under MSYS2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI builds for the mingw64 env, so actually use it. Otherwise various env vars are missing and PATH is wrong.
Use the shell provided by setup-msys2 instead of calling bash directly, no need to hardcode paths then.