-
-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Overhaul Coverity Scan #3566
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious how this will work, I left some minor suggestions.
Co-authored-by: Nicklas Larsson <[email protected]>
Co-authored-by: Nicklas Larsson <[email protected]>
Co-authored-by: Nicklas Larsson <[email protected]>
Co-authored-by: Nicklas Larsson <[email protected]>
Co-authored-by: Nicklas Larsson <[email protected]>
Co-authored-by: Nicklas Larsson <[email protected]>
Co-authored-by: Nicklas Larsson <[email protected]>
The variables in the Settings are set. |
Thanks @jadenabrams100 ! The workflow worked fine https://github.com/OSGeo/grass/actions/runs/8613750220, but some 3 hrs after still no update on Coverity... See the exemplary commit message 88f73e2: the relevant and potentially important information you first put in in-code comments, is better placed there. |
Thank you for example on how to format the commit messages properly! I checked this morning to see if it worked and have been looking into it for the past few hours. I do think it worked properly on our end (given the output from the action looks very similar to PROJ's), so I am not sure why it is not updating on the Coverity website. I sent an email to the Coverity Scan admin explaining our situation and will report back with what he says. |
There are two possible reasons:
|
#3572 is an attempt to address this. |
This PR attempts to fix the problems with the previously submitted Coverity Scanning action. Basic building functionality is borrowed from our ubuntu.yml, and Coverity functionality is borrowed from PROJ's coverity-scan.yml.
The needed secrets are: