Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checks: Update Bandit to ignore secure random warning (Rule B311) #3554

Merged

Conversation

Ntp9413
Copy link
Contributor

@Ntp9413 Ntp9413 commented Apr 2, 2024

@wenzeslaus has indicated that all use of random generators are not for cryptographic purposes in issue #3553 . Knowing this, these alerts are false positives and can be safely ignored.

This PR adds in a skip to the bandit configuration in pyproject.toml for rule B311. This rule searches for instances of randomizers used for potential cryptography.

@github-actions github-actions bot added the Python Related code is in Python label Apr 2, 2024
@echoix echoix added this to the 8.4.0 milestone Apr 2, 2024
@echoix echoix merged commit c617f0b into OSGeo:main Apr 2, 2024
26 checks passed
@echoix
Copy link
Member

echoix commented Apr 2, 2024

Thanks @Ntp9413!

@echoix echoix linked an issue Apr 3, 2024 that may be closed by this pull request
@wenzeslaus wenzeslaus changed the title Update Bandit to ignore secure random warning (Rule B311) checks: Update Bandit to ignore secure random warning (Rule B311) Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Python Related code is in Python
Projects
Development

Successfully merging this pull request may close these issues.

[Feat] Ignore Bandit's random generators not suitable for security
2 participants