Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contributing: Add autogenerated documentation to gitignore #3522

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

marisn
Copy link
Contributor

@marisn marisn commented Mar 22, 2024

As long as we have in-tree build system, our .gitignore has to grow.
Fixes #3521

@neteler
Copy link
Member

neteler commented Mar 23, 2024

(please make the PR title compatible with an entry in https://github.com/OSGeo/grass/blob/main/utils/release.yml as the release notes are autogenerated)

@marisn
Copy link
Contributor Author

marisn commented Mar 23, 2024

(please make the PR title compatible with an entry in https://github.com/OSGeo/grass/blob/main/utils/release.yml as the release notes are autogenerated)

I do not think this is something that should go to release notes.

@neteler
Copy link
Member

neteler commented Mar 23, 2024

Ok. Still I have to check line manually and, in this case, delete it from the extracted PR notes.

@echoix
Copy link
Member

echoix commented Mar 27, 2024

What about the "infra:" prefix?
Also, I'm not sure that it excludes everything either, except if I build it myself. Do we take the approach of merging this and having to complete afterwards when we figure out if the python docs create more files.

@marisn marisn changed the title Add autogenerated documentation to gitignore infra: Add autogenerated documentation to gitignore Mar 28, 2024
@marisn marisn requested a review from neteler March 28, 2024 05:59
Copy link
Member

@neteler neteler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

(Un)related: the "infra:" keyword needs to be added to https://github.com/OSGeo/grass/blob/main/utils/release.yml

@echoix echoix merged commit a34dcf3 into OSGeo:main Mar 28, 2024
26 checks passed
@neteler neteler changed the title infra: Add autogenerated documentation to gitignore contributing: Add autogenerated documentation to gitignore Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Ensure doc compilation files are ignored in .gitignore
3 participants