Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r.univar: init max value with smallest possible value #3512

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Mar 18, 2024

Init max value with smallest possible value, DBL_MIN is still a positive value.

Closes: #3497

@github-actions github-actions bot added raster Related to raster data processing C Related code is in C module labels Mar 18, 2024
@nilason nilason added bug Something isn't working backport to 8.3 labels Mar 18, 2024
@nilason nilason added this to the 8.4.0 milestone Mar 18, 2024
@nilason nilason requested review from wenzeslaus and anikaweinmann and removed request for anikaweinmann March 18, 2024 15:18
@github-actions github-actions bot added Python Related code is in Python tests Related to Test Suite labels Mar 18, 2024
@nilason
Copy link
Contributor Author

nilason commented Mar 18, 2024

Just to clarify, the following was never true for a negative value (val) if zd->max = DBL_MIN:

if (val > zd->max)

@nilason nilason self-assigned this Mar 19, 2024
@echoix echoix merged commit 68ca15d into OSGeo:main Mar 21, 2024
25 checks passed
nilason added a commit to nilason/grass that referenced this pull request Mar 25, 2024
nilason added a commit that referenced this pull request Mar 25, 2024
@nilason nilason deleted the fix_r_univar branch May 15, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working C Related code is in C module Python Related code is in Python raster Related to raster data processing tests Related to Test Suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] r.univar returns nan for rasters with only negative values
2 participants